Add constraint for authorization list tag ordering#59
Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
Closed
Add constraint for authorization list tag ordering#59copybara-service[bot] wants to merge 0 commit intomainfrom
copybara-service[bot] wants to merge 0 commit intomainfrom
Conversation
862e7d5 to
44b13b3
Compare
|
Some devices in the field violate this constraint.
Strictly enforcing ordering (or even ASN.1 SET canonical ordering, which is also sometimes violated) will cause devices to trip checks even though semantically everything is fine. All these device are GMS-certified and ship with Goole Play services and are somewhat recent (IIRC one is running Android 14). Sadly, I cannot publicly share data to back up my claims. |
Collaborator
|
This change adds the option to enforce ordering. It's not setting enforcement as the default. |
|
All I am saying is the ability to enable strict checks like those should come with a warning aimed at those integrating the library. |
3397a0f to
a3c4aa1
Compare
a3c4aa1 to
a6e9faf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add constraint for authorization list tag ordering