Skip to content

Add constraint for authorization list tag ordering#59

Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
test_850151679
Closed

Add constraint for authorization list tag ordering#59
copybara-service[bot] wants to merge 0 commit intomainfrom
test_850151679

Conversation

@copybara-service
Copy link

Add constraint for authorization list tag ordering

@copybara-service copybara-service bot force-pushed the test_850151679 branch 2 times, most recently from 862e7d5 to 44b13b3 Compare January 7, 2026 16:00
@JesusMcCloud
Copy link

JesusMcCloud commented Feb 4, 2026

Some devices in the field violate this constraint.
Unrelated but

  • various devices in the field also violate DER by encoding explicitly encoding critical = false into the attestation extension in the leaf
  • various devices in the field encode an ASN.1 boolean as 0x01 instead of 0xFF, also violating DER.

Strictly enforcing ordering (or even ASN.1 SET canonical ordering, which is also sometimes violated) will cause devices to trip checks even though semantically everything is fine.

All these device are GMS-certified and ship with Goole Play services and are somewhat recent (IIRC one is running Android 14). Sadly, I cannot publicly share data to back up my claims.

@carmenyh
Copy link
Collaborator

carmenyh commented Feb 4, 2026

This change adds the option to enforce ordering. It's not setting enforcement as the default.

@JesusMcCloud
Copy link

All I am saying is the ability to enable strict checks like those should come with a warning aimed at those integrating the library.

@copybara-service copybara-service bot force-pushed the test_850151679 branch 7 times, most recently from 3397a0f to a3c4aa1 Compare February 10, 2026 16:08
@copybara-service copybara-service bot closed this Feb 10, 2026
@copybara-service copybara-service bot deleted the test_850151679 branch February 10, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants