Revert "perf(@angular/build): skip semantic affected-file walk when type checking is disabled"#33640
Merged
Merged
Conversation
alan-agius4
added
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the condition for determining affected files in AotCompilation by removing the useTypeScriptTranspilation check. However, the reviewer notes that this change can lead to incorrect build outputs when type-checking is disabled but TypeScript transpilation is active, as it skips the affected files walk. The reviewer recommends retaining the check and provides a code suggestion to define useTypeScriptTranspilation using the compiler options.
alan-agius4
force-pushed
the
fix-22-0-x-build
branch
from
July 23, 2026 10:08
3378991 to
208f12e
Compare
alan-agius4
changed the title
…ype checking is disabled" This reverts commit 2462709.
alan-agius4
force-pushed
the
fix-22-0-x-build
branch
from
July 23, 2026 10:16
208f12e to
0042513
Compare
crisbeto
approved these changes
Jul 23, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2462709.