-
Notifications
You must be signed in to change notification settings - Fork 0
fix: visor dash styling #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2361b62
up
ansBAkula 131d8e9
up
ansBAkula 4bfe8f3
clean-up
ansBAkula 67a1c71
chore: adding changelog file 109.fixed.md [dependabot-skip]
pyansys-ci-bot 0839b5b
code fixes for tests
ansBAkula 9783e7b
prettier fix
ansBAkula 683c599
address Lauras comment
ansBAkula f48ab18
address Lauras comment
ansBAkula 07fbfa4
chore: trigger CI
ansBAkula b66a71b
Merge branch 'main' into fix/visor_dash_styling
ansBAkula 1f586b5
Merge branch 'main' into fix/visor_dash_styling
ansBAkula File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Visor dash styling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /** | ||
| * Helpers to resolve a scoped portal root for UI elements that would | ||
| * otherwise be appended to `document.body` (tooltips, popups, invisible | ||
| * DOM containers used by wasm). Prefer an element with the | ||
| * `.visor-embed-style` class (added by host integrations), then fall back | ||
| * to the client container id `VisorContainer`, and finally to a dedicated | ||
| * `visor-portal-root` element created under `document.body`. | ||
| * | ||
| * A single JS implementation is kept (no separate .ts version) so there is | ||
| * one source of truth; JSDoc types below give TS/TSX consumers proper typing. | ||
| * | ||
| * @returns {HTMLElement} | ||
| */ | ||
| export function getPortalRoot() { | ||
| const doc = typeof document !== 'undefined' ? document : null; | ||
| if (!doc) { | ||
| // Non-browser environment (SSR). Return a harmless stub to avoid | ||
| // throwing in places that call this helper during static analysis. | ||
| // Callers should guard when used outside the browser. | ||
| return /** @type {HTMLElement} */ ({}); | ||
| } | ||
|
|
||
| const el = doc.querySelector('.visor-embed-style') || doc.getElementById('VisorContainer'); | ||
| if (el) return /** @type {HTMLElement} */ (el); | ||
|
|
||
| let portalRoot = doc.getElementById('visor-portal-root'); | ||
| if (!portalRoot) { | ||
| portalRoot = doc.createElement('div'); | ||
| portalRoot.id = 'visor-portal-root'; | ||
| portalRoot.setAttribute('data-visor-portal', '1'); | ||
| doc.body.appendChild(portalRoot); | ||
| } | ||
|
|
||
| return portalRoot; | ||
| } | ||
|
|
||
| /** | ||
| * @param {HTMLElement} el | ||
| * @returns {void} | ||
| */ | ||
| export function appendToPortal(el) { | ||
| getPortalRoot().appendChild(el); | ||
| } | ||
|
|
||
| /** | ||
| * @param {HTMLElement} el | ||
| * @returns {void} | ||
| */ | ||
| export function removeFromPortal(el) { | ||
| if (el && el.parentElement) { | ||
| el.parentElement.removeChild(el); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.