Av/711 migrate to latest OIDC - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
Summary
oidc^0.14.0→^4.0.0,oidc_core^0.16.0→^3.0.0,oidc_default_store^0.6.0→^1.0.0(three major releases: 1.0.0, 2.0.0, 3.0.0/4.0.0). Raises the environment floor to Dart>=3.11.0/ Flutter>=3.41.0, required by the newoidc_darwinplugin (which mergesoidc_ios+oidc_macos).initMode: OidcInitMode.blockingValidateinSolidOidcManagerFactory.oidc_core2.0+ changedinit()'s default tocacheFirst.SolidAuthManager.tryRestoreSession()readscurrentAuthDatasynchronously right afterinit()resolves, so it needs the old guarantee that an expired token is already refreshed by the timeinit()returns.SolidOidcConfig.strictJwtVerificationtoOidcUserManagerSettings- the corresponding constructor parameter no longer exists inoidc_core1.0+, which removed the fail-open opt-out entirely (ID token signature verification is now unconditionally strict). The field is kept onSolidOidcConfigas a documented no-op so existing call sites don't fail to compile.Related Issues
anusii/solidpod#711
Type of Change
How To Test?
Run solid_auth example app and login to any community solid server and check if the auth flow works.
Checklist
make preporflutter analyze lib)dart testoutput or screenshot included in issue #Finalising