Generalize _merge_with_lcs and _pair_adjacent_changes#93
Open
pmolodo wants to merge 1 commit intopmolodowitch/diff-feature-testsfrom
Open
Generalize _merge_with_lcs and _pair_adjacent_changes#93pmolodo wants to merge 1 commit intopmolodowitch/diff-feature-testsfrom
pmolodo wants to merge 1 commit intopmolodowitch/diff-feature-testsfrom
Conversation
Collaborator
pmolodo
commented
May 1, 2026
pmolodo
commented
- Extract the LCS-driven walk that was inlined inside diff_block_lists (and duplicated inside diff_list_nodes) into a single generic _merge_with_lcs that returns an ordered (op, element) stream.
- Generalize _pair_adjacent_changes to take pair / wrap_deletion / wrap_insertion callbacks so it can fold the same stream for both Pandoc blocks and list items, instead of operating on already-wrapped Divs.
- Add _pair_blocks helper carrying the per-pair recursion strategy (lists / BlockQuotes / LineBlocks) used by diff_block_lists.
- Reduce diff_list_nodes from a hand-written merge+pair loop to a thin call into the shared helpers.
- Extract the LCS-driven walk that was inlined inside diff_block_lists (and duplicated inside diff_list_nodes) into a single generic _merge_with_lcs that returns an ordered (op, element) stream. - Generalize _pair_adjacent_changes to take pair / wrap_deletion / wrap_insertion callbacks so it can fold the same stream for both Pandoc blocks and list items, instead of operating on already-wrapped Divs. - Add _pair_blocks helper carrying the per-pair recursion strategy (lists / BlockQuotes / LineBlocks) used by diff_block_lists. - Reduce diff_list_nodes from a hand-written merge+pair loop to a thin call into the shared helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.