Fix exception bug with executeFateOperation

[kevinrr888]

ThriftPropertyException was declared as thrown by
FateServiceHandler.executeFateOperation but not by manager.thrift.executeFateOperation, resulting in the client receiving an exception without info about the cause.

I noticed this working on #6040, where I need to throw a ThriftPropertyException and noticed I was not receiving the expected error to the client

[kevinrr888]

Here is a test that demonstrates the problem:

  @Test
  public void TEMP() throws Exception {
    String[] names = getUniqueNames(2);
    String src = names[0];
    String dst = names[1];
    client.tableOperations().create(src);
    client.tableOperations().clone(src, dst, CloneConfiguration.builder().setPropertiesToSet(Map.of("random.invalid.key", "123")).build());
  }

Before:

org.apache.accumulo.core.client.AccumuloException: Internal error processing executeFateOperation

	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:412)
	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:364)
	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.doTableFateOperation(TableOperationsImpl.java:1803)
	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.clone(TableOperationsImpl.java:801)
	at org.apache.accumulo.test.IteratorEnvIT.TEMP(IteratorEnvIT.java:232)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: org.apache.thrift.TApplicationException: Internal error processing executeFateOperation
	at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:81)
	at org.apache.accumulo.core.manager.thrift.FateService$Client.recv_executeFateOperation(FateService.java:134)
	at org.apache.accumulo.core.manager.thrift.FateService$Client.executeFateOperation(FateService.java:115)
	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.executeFateOperation(TableOperationsImpl.java:289)
	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:375)
	... 9 more

After:

org.apache.accumulo.core.client.AccumuloException
	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:412)
	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:364)
	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.doTableFateOperation(TableOperationsImpl.java:1803)
	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.clone(TableOperationsImpl.java:801)
	at org.apache.accumulo.test.IteratorEnvIT.TEMP(IteratorEnvIT.java:232)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: ThriftPropertyException(property:random.invalid.key, value:123, description:Invalid Table Property random.invalid.key=123)
	at org.apache.accumulo.core.manager.thrift.FateService$executeFateOperation_result$executeFateOperation_resultStandardScheme.read(FateService.java:3876)
	at org.apache.accumulo.core.manager.thrift.FateService$executeFateOperation_result$executeFateOperation_resultStandardScheme.read(FateService.java:3834)
	at org.apache.accumulo.core.manager.thrift.FateService$executeFateOperation_result.read(FateService.java:3759)
	at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:93)
	at org.apache.accumulo.core.manager.thrift.FateService$Client.recv_executeFateOperation(FateService.java:134)
	at org.apache.accumulo.core.manager.thrift.FateService$Client.executeFateOperation(FateService.java:115)
	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.executeFateOperation(TableOperationsImpl.java:289)
	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:375)
	... 9 more

[keith-turner]

Here is a test that demonstrates the problem:

Would it be possible to make that snippet of example code into an IT that ensures we get a nice error message back?

Wondering if there are any other places in the code where server side config validation failure does not result in a useful client side error message.

[keith-turner]

When changing thrift IDL in a bug fix release we need to consider how this will impact something like a 2.1.4 client and 2.1.5 sever or visa versa. Not really sure if this change will cause problems or not for those situations, do you know?