Convert check-sdk-imports to capture occurences than files - #71212
Merged
amoghrajesh merged 3 commits intoAug 11, 2026
Conversation
amoghrajesh
requested review from
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
August 6, 2026 05:26
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-3-test
jason810496
reviewed
Aug 6, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Thanks! Yeah, it makes sense to follow the know_....txt convention.
ferruzzi
reviewed
Aug 6, 2026
ferruzzi
left a comment
ferruzzi
left a comment
Contributor
There was a problem hiding this comment.
Two thoughts, non-blocking. Thanks for taking this on.
kaxil
approved these changes
Aug 7, 2026
jason810496
approved these changes
Aug 11, 2026
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
The hook was meant to stop airflow-core from gaining new runtime dependencies on the task SDK, but it worked by excluding whole files that already had an import when the check was added. That made it blind to new imports added later to any of those files - which is exactly what happened in #70370, where a new
airflow.sdkimport landedin
models/taskinstance.pyunnoticed because the file was already on the exclude list for an older, unrelated import.Track an allowed import count per file instead (same pattern as
check_new_airflow_exception_usage.py), so existing file can't quietly gain more without either a# noqa: SDK001or a deliberate allowlist regeneration.{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.