Store executor callback DagRun references in the database - #71214
Open
fat-catTW wants to merge 1 commit into
Open
Store executor callback DagRun references in the database#71214fat-catTW wants to merge 1 commit into
fat-catTW wants to merge 1 commit into
Conversation
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
from
August 6, 2026 07:31
b24bdc4 to
40f7be8
Compare
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
from
August 9, 2026 15:00
40f7be8 to
26897c6
Compare
uranusjr
reviewed
Aug 9, 2026
Comment on lines
+1272
to
1278
| dag_run = callback.dag_run | ||
| if dag_run is None: | ||
| self.log.warning( | ||
| "Could not find DagRun with id=%s for callback %s. DagRun may have been deleted.", | ||
| dag_run_id, | ||
| callback.dagrun_id, | ||
| callback.id, | ||
| ) |
Member
There was a problem hiding this comment.
This collapses two previously distinct failure modes (missing dagrun_id due to a callback-creation bug vs. a DagRun deleted after enqueue) into one warning path. Only one production call site sets dagrun_id today, so it's not reachable now, but it'd be easy for a future ExecutorCallback creation path to forget to set it and silently emits "DagRun may have been deleted."
Maybe add different checks to callback.dagrun_id is None and dag_run is None with dagrun_id set?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Executor callbacks need to know which DagRun they belong to when the scheduler
builds callback workloads. Keeping that reference only in
callback.datamakesthe scheduler depend on payload shape instead of a database-managed relationship.
Solution
Add a nullable
callback.dagrun_idforeign key todag_run.idand have executorcallbacks store their DagRun reference there. The scheduler now loads the
relationship through the ORM when enqueueing callback workloads.
The migration backfills existing rows from deadline relationships first, then
falls back to legacy callback payload data when needed.
Was generative AI tooling used to co-author this PR?
[X]Yes (please specify the tool below)Generated-by: [Codex] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.