Skip to content

feat(python/adbc_driver_manager): allow connect(profile="foo")#4078

Merged
lidavidm merged 1 commit intoapache:mainfrom
lidavidm:gh-4077
Mar 13, 2026
Merged

feat(python/adbc_driver_manager): allow connect(profile="foo")#4078
lidavidm merged 1 commit intoapache:mainfrom
lidavidm:gh-4077

Conversation

@lidavidm
Copy link
Member

Closes #4077.

@lidavidm lidavidm requested review from amoeba and ianmcook March 12, 2026 02:17
@lidavidm lidavidm marked this pull request as ready for review March 12, 2026 04:35
@ianmcook
Copy link
Member

ianmcook commented Mar 12, 2026

Tested and mostly works as expected. Thanks @lidavidm.

One small unexpected behavior: If I specify connect(driver="invalid", profile="foo"), and the connection profile foo specifies a valid driver, it succeeds. I would have expected that to fail.

@lidavidm
Copy link
Member Author

One small unexpected behavior: If I specify connect(driver="invalid", profile="foo"), and the connection profile foo specifies a valid driver, it succeeds. I would have expected that to fail.

I think that's handled by the C++ driver manager itself, so I'll investigate that as a separate issue.

@lidavidm lidavidm merged commit adea2d7 into apache:main Mar 13, 2026
82 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python/adbc_driver_manager: allow connect(profile="foo")

2 participants