GH-139: [Flight] Stop return null from MetadataAdapter.getAll(String) and getAllByte(String)#1016
Open
axreldable wants to merge 1 commit intoapache:mainfrom
Open
GH-139: [Flight] Stop return null from MetadataAdapter.getAll(String) and getAllByte(String)#1016axreldable wants to merge 1 commit intoapache:mainfrom
axreldable wants to merge 1 commit intoapache:mainfrom
Conversation
…tring) and getAllByte(String)
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Please add the |
ennuite
approved these changes
Feb 10, 2026
Contributor
ennuite
left a comment
There was a problem hiding this comment.
Hello @axreldable
This looks good to me, thank you for it.
I note that this also fixes an NPE in MetadataAdapter.getAllByte(String key)
Contributor
Author
Correct, it fixes NPE for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
CallHeadershas 3 implementations:Before this change:
MetadataAdaptercould returnnullfromgetAll(String)andgetAllByte(String)when there were no values for the key, because gRPC’sMetadata.getAll()returnsnullin that case. This was undocumented and forced callers to null-check.After this change:
All 3 implementations consistently return an
empty iterable(nevernull) when the key is absent or has no values. The contract is documented on the interface and covered by tests for each implementation.This contains breaking changes.
MetadataAdapter.getAll(String)andgetAllByte(String)return empty iterator instead of null.Closes #139.