GH-48675: [C++][FlightRPC] Document StatementAttributeId enum values in ODBC SPI #48676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
Member
|
CC @alinaliBQ |
github-actions
bot
added
awaiting committer review
lidavidm
approved these changes
Jan 3, 2026
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit a9f0a4a. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ed36107ad8#diff-cbd67e664d899cd38324e1b1a05b073722bd9c011a3449127c408efcf2f1592eR42-R52
There is a todo in ed36107ad8 which I presume that the author just forgot to do it.
What changes are included in this PR?
This PR simply moves the comments to the docs to the attributes per Doxygen.
Are these changes tested?
No, I did not test.
Are there any user-facing changes?
No, I believe this is an internal API.