MINOR: [C++][FlightRPC] Clarify IsAutoUnique equivalence between ODBC 2.0 and 3.0+ #48689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
Member
|
CC @alinaliBQ |
HyukjinKwon
force-pushed
the
todo-odbc
branch
from
8a21968 to
6f14bf3
Compare
HyukjinKwon
force-pushed
the
todo-odbc
branch
from
6f14bf3 to
51ca4fc
Compare
HyukjinKwon
changed the title
alinaliBQ
approved these changes
Jan 2, 2026
Comment on lines
+225
to
+227
| // AUTO_UNIQUE_VALUE (ODBC 3.0+) is equivalent to | ||
| // AUTO_INCREMENT (ODBC 2.0). Both indicate columns | ||
| // that automatically generate unique values. |
Contributor
There was a problem hiding this comment.
Yes the statement is correct.
github-actions
bot
added
awaiting committer review
lidavidm
approved these changes
Jan 3, 2026
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 582d99c. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Clarify that
IsAutoUnique()correctly maps to both ODBC 2.0 (AUTO_INCREMENT) and ODBC 3.0+ (AUTO_UNIQUE_VALUE) concepts, resolving a TODO comment.Reference: https://learn.microsoft.com/en-us/sql/odbc/reference/syntax/sqlgettypeinfo-function?view=sql-server-ver17
What changes are included in this PR?
Replace the todo to the explanation of the equivalence.
Are these changes tested?
No, I did not test.
Are there any user-facing changes?
No, dev-only.