GH-50707: [C++][Gandiva] Fix out-of-bounds read in mask functions - #50733
Closed
KHARSHAVARDHAN-eng wants to merge 1 commit into
Closed
GH-50707: [C++][Gandiva] Fix out-of-bounds read in mask functions#50733KHARSHAVARDHAN-eng wants to merge 1 commit into
KHARSHAVARDHAN-eng wants to merge 1 commit into
Conversation
github-actions
Bot
added
Component: C++
Component: Gandiva
awaiting review
Member
|
@KHARSHAVARDHAN-eng this is going to be my 4th attempt to interact with you. I'll start closing your PRs if you don't come back to us. Please act on feedback on your previous PRs before opening new ones. |
Author
|
@raulcd , i will review all my prev pr and make changes in them.. Thanks !!! |
Contributor
|
@KHARSHAVARDHAN-eng, This issue has been already assigned to someone, so pls work on the ones we have already given feedback on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included?
Fix out-of-bounds reads in Gandiva UTF-8 masking functions by passing the remaining buffer length to
utf8proc_iterate()instead of the original string length after advancing the input pointer.Also adds missing error handling for invalid UTF-8 sequences and regression tests covering truncated multi-byte UTF-8 inputs.
Why are these changes needed?
The previous implementation advanced the input pointer while continuing to pass the original buffer length to
utf8proc_iterate(). This could allow reads beyond the remaining valid buffer.Tests