GH-50737: [C++][Parquet] mark MakeStatistics method without ColumnDescriptor as deprecated - #50738
Open
HuaHuaY wants to merge 1 commit into
Open
GH-50737: [C++][Parquet] mark MakeStatistics method without ColumnDescriptor as deprecated#50738HuaHuaY wants to merge 1 commit into
MakeStatistics method without ColumnDescriptor as deprecated#50738HuaHuaY wants to merge 1 commit into
Conversation
|
|
Contributor
Author
|
@pitrou Please take a look. What do you think about marking this method as deprecated? |
Member
pitrou
approved these changes
Jul 30, 2026
github-actions
Bot
added
awaiting committer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I offer two reasons for marking this method as deprecated:
distinct_countparameter but lackshas_distinct_count, making it impossible to represent missing distinct counts, which could lead to misuse.nan_count, I found that it lacks aColumnDescriptorparameter, making it impossible to obtain the logical type and determine the value ofhas_nan_countbased on Parquet's logical type (FLOAT16).What changes are included in this PR?
Mark
MakeStatisticsmethod withoutColumnDescriptoras deprecated.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
Mark
MakeStatisticsmethod withoutColumnDescriptoras deprecated.MakeStatisticswithoutColumnDescriptoras deprecated #50737