ARTEMIS-6146 Large Message inconsistencies through Divert and Mirror#6564
Merged
Conversation
clebertsuconic
force-pushed
the
ARTEMIS-6146
branch
from
66152e5 to
da93874
Compare
clebertsuconic
force-pushed
the
ARTEMIS-6146
branch
5 times, most recently
from
9d1122b to
5fc429b
Compare
jbertram
reviewed
Jul 7, 2026
jbertram
reviewed
Jul 7, 2026
clebertsuconic
force-pushed
the
ARTEMIS-6146
branch
2 times, most recently
from
88a25d4 to
63de6f7
Compare
gemmellr
reviewed
Jul 8, 2026
gemmellr
reviewed
Jul 8, 2026
Contributor
Author
|
This is not as simple as I thought. there are other cases where we could have issues.. and I'm writing more tests to capture them. |
clebertsuconic
force-pushed
the
ARTEMIS-6146
branch
from
3bbce93 to
b7c0117
Compare
Contributor
Author
|
There was an issue also with the RoutingContext on the Divert not respecting the expiry settings on mirror. I have fixed those cases. |
clebertsuconic
force-pushed
the
ARTEMIS-6146
branch
2 times, most recently
from
93b96d2 to
22794a7
Compare
clebertsuconic
changed the title
clebertsuconic
force-pushed
the
ARTEMIS-6146
branch
3 times, most recently
from
8b181d5 to
f02ee06
Compare
clebertsuconic
commented
Jul 9, 2026
clebertsuconic
force-pushed
the
ARTEMIS-6146
branch
from
f02ee06 to
975214f
Compare
When sending a large message following a Divert, the large message file could be corrupted in a few cases. Also there were a few inconsistencies between mirror and Diverts. I added an integration test at AMQPMirrorLargeMessageDivertDroppedTest where I found a few issues. These issues were captured at PostOfficeImplTest on mock tests.
clebertsuconic
force-pushed
the
ARTEMIS-6146
branch
from
975214f to
bca8e5a
Compare
Contributor
Author
|
I need to merge this.. if anyone needs anything I will follow up with another commit. thanks for the reviews guys. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.