[AURON #1757] Add cleanup logic to prevent flaky tests caused by leftover locations#1758
Merged
richox merged 1 commit intoapache:masterfrom Jan 27, 2026
Merged
Conversation
9430134 to
436889c
Compare
82dfdf7 to
b72b7a6
Compare
richox
approved these changes
Dec 26, 2025
…y Leftover Locations
b72b7a6 to
08f306a
Compare
Contributor
Author
|
@cxzl25 Could you help merge this PR? |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses flaky tests caused by leftover managed table locations from interrupted test runs. The changes add workspace cleanup logic to BaseAuronSQLSuite to ensure a clean environment before tests execute, preventing LOCATION_ALREADY_EXISTS errors when tests are rerun.
Changes:
- Added workspace directory management with cleanup logic in BaseAuronSQLSuite's beforeAll() method
- Configured spark.sql.warehouse.dir to use a dedicated warehouse directory per suite
- Modified visibility modifiers in BuildInfoInSparkUISuite from protected to public for beforeAll/afterAll methods
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| spark-extension-shims-spark/src/test/scala/org/apache/auron/BaseAuronSQLSuite.scala | Added workspace initialization and cleanup infrastructure with beforeAll/afterAll lifecycle methods, plus warehouse directory configuration |
| spark-extension-shims-spark/src/test/scala/org/apache/spark/sql/execution/BuildInfoInSparkUISuite.scala | Changed visibility modifiers from protected to public for beforeAll/afterAll methods to match parent trait requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spark-extension-shims-spark/src/test/scala/org/apache/auron/BaseAuronSQLSuite.scala
Show resolved
Hide resolved
spark-extension-shims-spark/src/test/scala/org/apache/auron/BaseAuronSQLSuite.scala
Show resolved
Hide resolved
spark-extension-shims-spark/src/test/scala/org/apache/auron/BaseAuronSQLSuite.scala
Show resolved
Hide resolved
spark-extension-shims-spark/src/test/scala/org/apache/auron/BaseAuronSQLSuite.scala
Show resolved
Hide resolved
...sion-shims-spark/src/test/scala/org/apache/spark/sql/execution/BuildInfoInSparkUISuite.scala
Show resolved
Hide resolved
spark-extension-shims-spark/src/test/scala/org/apache/auron/BaseAuronSQLSuite.scala
Show resolved
Hide resolved
richox
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1757
Rationale for this change
What changes are included in this PR?
BaseAuronSQLSuite: reset suite workspace and set spark.sql.warehouse.dir
Are there any user-facing changes?
How was this patch tested?