[AURON #1875] Minor refactor: move legacy spark version compatibility methods to Shims.scala #1876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yew1eb
force-pushed
the
AURON_1875
branch
2 times, most recently
from
b9cc7c4 to
acce34a
Compare
yew1eb
changed the title
yew1eb
changed the title
yew1eb
force-pushed
the
AURON_1875
branch
2 times, most recently
from
b8eff39 to
baeb8fb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors legacy Spark version compatibility methods by moving them from AuronConverters.scala to the Shims abstraction layer, improving code organization and maintainability.
Changes:
- Added three abstract method definitions in
Shims.scalafor version-specific Spark compatibility - Implemented these methods in
ShimsImpl.scalawith appropriate@sparkverannotations for different Spark versions - Updated call sites in
AuronConverters.scalato use the new shim methods viaShims.get
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spark-extension/src/main/scala/org/apache/spark/sql/auron/Shims.scala | Added abstract method declarations for getIsSkewJoinFromSHJ, getShuffleOrigin, and isNullAwareAntiJoin with appropriate imports |
| spark-extension-shims-spark/src/main/scala/org/apache/spark/sql/auron/ShimsImpl.scala | Moved the version-specific implementations of the three methods from AuronConverters to ShimsImpl with @sparkver annotations |
| spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala | Removed method definitions and updated call sites to use Shims.get. instead; removed unused sparkver import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spark-extension-shims-spark/src/main/scala/org/apache/spark/sql/auron/ShimsImpl.scala
Outdated
Show resolved
Hide resolved
spark-extension-shims-spark/src/main/scala/org/apache/spark/sql/auron/ShimsImpl.scala
Outdated
Show resolved
Hide resolved
yew1eb
force-pushed
the
AURON_1875
branch
5 times, most recently
from
8e2f7b8 to
934fc92
Compare
…bility methods to Shims.scala
Contributor
Author
|
cc @richox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1875
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?