[AURON #1940] Extract Rust test logic to standalone CI workflow #1941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts Rust test and lint logic into a standalone CI workflow to improve separation of concerns and maintainability.
Changes:
- Removed cargo fix, fmt, and clippy commands from the build script (which were modifying source code during builds)
- Removed Rust testing steps from the TPC-DS reusable workflow
- Created a new dedicated
rust-test.ymlworkflow for Rust linting and testing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dev/mvn-build-helper/build-native.sh | Removed cargo fix, fmt, and clippy commands that were auto-modifying code during build |
| .github/workflows/tpcds-reusable.yml | Removed rustfmt/clippy components and cargo test/clippy steps that are now in dedicated workflow |
| .github/workflows/rust-test.yml | New standalone workflow for Rust formatting checks, linting, and testing with appropriate triggers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
cc @richox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1940
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?