-
Notifications
You must be signed in to change notification settings - Fork 207
[AURON #1937][CI] Enable TPCDS test q14b #1946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit e73ae8c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses a thread-safety issue in the deserializeExpression method by adding synchronization around object deserialization when a TaskContext is present. The fix re-enables the previously flaky q14b TPC-DS query test.
Changes:
- Added synchronization on
taskMetrics()during expression deserialization to fix thread-safety issues with Spark'sTaskMetrics#externalAccums - Re-enabled q14b in the TPC-DS test suite after addressing the flaky failure
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala | Added TaskContext import and synchronized block around readObject calls in deserializeExpression to fix thread-safety issue |
| .github/workflows/tpcds-reusable.yml | Re-enabled q14b test and removed the comment about the flaky failure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala
Outdated
Show resolved
Hide resolved
…veConverters.scala Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala
Show resolved
Hide resolved
|
Nice fix @cxzl25! Could you share the root cause and troubleshooting clues for this q14b issue? |
Judging from the call stack, the accumUpdates of TaskResult contains null values. ERROR TaskResultGetter: Exception while getting task result
java.lang.NullPointerException
at org.apache.spark.scheduler.TaskResultGetter$$anon$3.$anonfun$run$3(TaskResultGetter.scala:109)The only place where Since |
Which issue does this PR close?
Closes #1937
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?