Bump Jetty to 12.1.10 and fix binary license metadata - #4871
Merged
merlimat merged 2 commits intoSep 10, 2026
Merged
Conversation
Bumps org.eclipse.jetty:jetty-server from 12.1.7 to 12.1.10. --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-server dependency-version: 12.1.10 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
merlimat
changed the title
merlimat
changed the base branch from
dependabot/maven/org.eclipse.jetty-jetty-server-12.1.10
to
master
September 9, 2026 23:46
merlimat
approved these changes
Sep 9, 2026
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Updates Jetty from 12.1.7 to 12.1.10 and aligns the checked-in binary LICENSE/NOTICE manifests so BookKeeper’s license gate recognizes the new Jetty artifacts.
Changes:
- Bump
jetty.versioninpom.xmlto 12.1.10. - Update Jetty jar entries in
NOTICE-*.bin.txtmanifests to 12.1.10. - Update Jetty jar entries and Jetty source link in
LICENSE-*.bin.txtmanifests to 12.1.10.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Bumps Jetty dependency version to 12.1.10. |
| bookkeeper-dist/src/main/resources/NOTICE-server.bin.txt | Updates Jetty jar names listed in server binary NOTICE. |
| bookkeeper-dist/src/main/resources/NOTICE-all.bin.txt | Updates Jetty jar names listed in “all” binary NOTICE. |
| bookkeeper-dist/src/main/resources/LICENSE-server.bin.txt | Updates Jetty jar names and Jetty source URL in server binary LICENSE. |
| bookkeeper-dist/src/main/resources/LICENSE-all.bin.txt | Updates Jetty jar names and Jetty source URL in “all” binary LICENSE. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
merlimat
pushed a commit
that referenced
this pull request
Sep 10, 2026
* build(deps-dev): bump org.eclipse.jetty:jetty-server Bumps org.eclipse.jetty:jetty-server from 12.1.7 to 12.1.10. --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-server dependency-version: 12.1.10 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> * Fix Jetty 12.1.10 binary license metadata --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #4849 by including the
jetty.versionbump (12.1.7 → 12.1.10) inpom.xmldirectly in this PR, alongside the LICENSE/NOTICE fix that the dependency bump requires.Companion fix for #4849.
The dependency upgrade itself builds successfully, but BookKeeper’s binary-license gate rejects the distributions because the four checked-in LICENSE/NOTICE manifests still name the nine Jetty 12.1.7 jars. This updates those exact entries and the Jetty source link to 12.1.10 in the all/server manifests.
Verification on JDK 17 using disposable JAIPilot Remote hardware:
mvn -T 4 -B -nsu clean install -Ddistributedlog -Dnative.io.pure.rust=true -DskipTestsdev/check-all-licensespassed for all three archivesgit diff --checkThe native module used the repository’s documented current-host pure-Rust profile because the remote image does not preinstall Zig/cargo-zigbuild. The source PR’s CI had already completed the cross-compiled build and failed only at the subsequent license-manifest check. The disposable workspace and uploaded source were deleted after verification.