Skip to content

docs: Add 'Execution of BuildStream Elements' page#2057

Draft
shymega-ct wants to merge 1 commit intoapache:masterfrom
shymega-ct:domrodriguez/add-execution_bst-doc
Draft

docs: Add 'Execution of BuildStream Elements' page#2057
shymega-ct wants to merge 1 commit intoapache:masterfrom
shymega-ct:domrodriguez/add-execution_bst-doc

Conversation

@shymega-ct
Copy link
Contributor

WIP!

Copy link
Contributor

@abderrahim abderrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. This document needs a rewrite as it has a lot of factual inaccuracies and wrong terminology.

Sources are fetched
-------------------

The hidden first step is actually validating the ``yaml``. This includes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "hidden" step needs to be "unhidden" in the documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean, specifically by this? Is there a specific page you could link to for context?


The hidden first step is actually validating the ``yaml``. This includes
resolving includes, options, appends, which are denoted by ``(@)``,
``(?)`` and ``(>)`` respectively.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to link to the rest of the documentation, having a document like this feels very weird.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any page in particular?

@shymega-ct shymega-ct force-pushed the domrodriguez/add-execution_bst-doc branch from 28300de to cf8d4e4 Compare September 15, 2025 20:02
@shymega-ct shymega-ct force-pushed the domrodriguez/add-execution_bst-doc branch from cf8d4e4 to 0efc86e Compare September 24, 2025 09:15
Copy link
Contributor

@juergbi juergbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this document contains useful information, however, the scope doesn't seem completely clear to me.

Looking at the current BuildStream documentation, I think we're indeed missing a good overview of the different stages for a given element during bst build, so it would be nice to have that.

However, this document includes a lot of details that I don't consider useful as part of an overview. We should link to other sections of the documentation for that (and expand other sections for details that aren't documented anywhere else right now).

I.e., I would define the scope of this page to be an overview of the build process of an element, as I think that's what we're missing most. Or did you have a different scope or target audience in mind? I'm open to other possibilities but I think we should be reasonably clear about what does and what does not belong on this new page.

@shymega-ct shymega-ct force-pushed the domrodriguez/add-execution_bst-doc branch from 0efc86e to ff93377 Compare February 5, 2026 20:23
@shymega-ct shymega-ct force-pushed the domrodriguez/add-execution_bst-doc branch from ff93377 to cbce641 Compare February 18, 2026 18:55
@shymega-ct shymega-ct force-pushed the domrodriguez/add-execution_bst-doc branch from cbce641 to fe968dc Compare February 26, 2026 15:32
@shymega-ct
Copy link
Contributor Author

@juergbi I agree broadly with your thoughts here. I am rewriting this based on your comment, to make it a MVP first, and then iterate upon it.

Would it be best to open a new PR, or keep this one?

@juergbi
Copy link
Contributor

juergbi commented Feb 26, 2026

Would it be best to open a new PR, or keep this one?

As this PR already has review comments, at least some of which may remain relevant, I'd probably keep this PR. Depending on how you approach this, a new PR could also be fine but please make sure to address or copy all existing review comments unless they don't apply at all anymore.

@shymega-ct shymega-ct force-pushed the domrodriguez/add-execution_bst-doc branch from fe968dc to d58df3f Compare February 28, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants