Skip to content

CAMEL-23592: camel-shiro - align Exchange header constant names with Camel naming convention #23506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oscerd merged 1 commit into from
May 27, 2026
+30 −3
Merged

CAMEL-23592: camel-shiro - align Exchange header constant names with Camel naming convention #23506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...shiro/src/main/java/org/apache/camel/component/shiro/security/ShiroSecurityConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
*/
public final class ShiroSecurityConstants {

public static final String SHIRO_SECURITY_TOKEN = "SHIRO_SECURITY_TOKEN";
public static final String SHIRO_SECURITY_USERNAME = "SHIRO_SECURITY_USERNAME";
public static final String SHIRO_SECURITY_PASSWORD = "SHIRO_SECURITY_PASSWORD";
public static final String SHIRO_SECURITY_TOKEN = "CamelShiroSecurityToken";
public static final String SHIRO_SECURITY_USERNAME = "CamelShiroSecurityUsername";
public static final String SHIRO_SECURITY_PASSWORD = "CamelShiroSecurityPassword";

private ShiroSecurityConstants() {
}
Expand Down
27 changes: 27 additions & 0 deletions docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_21.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,33 @@ directions, aligning the component with the rest of the Camel component catalog.
`Camel`-prefixed user-header names from Iggy messages can supply a custom `headerFilterStrategy`
to restore the previous behaviour.

=== camel-shiro - potential breaking change

The three Exchange header constants in `ShiroSecurityConstants` that drive
Shiro authentication used header values outside the `Camel` namespace
(`SHIRO_SECURITY_TOKEN`, `SHIRO_SECURITY_USERNAME`, `SHIRO_SECURITY_PASSWORD`)
and were therefore not filtered by the default `HeaderFilterStrategy`. They
have been renamed to follow the Camel naming convention. The Java field names
are unchanged; only the header string values have changed:

[options="header"]
|===
| Constant | Previous value | New value
| `ShiroSecurityConstants.SHIRO_SECURITY_TOKEN` | `SHIRO_SECURITY_TOKEN` | `CamelShiroSecurityToken`
| `ShiroSecurityConstants.SHIRO_SECURITY_USERNAME` | `SHIRO_SECURITY_USERNAME` | `CamelShiroSecurityUsername`
| `ShiroSecurityConstants.SHIRO_SECURITY_PASSWORD` | `SHIRO_SECURITY_PASSWORD` | `CamelShiroSecurityPassword`
|===

These headers carry credentials and a serialized authentication token, so
filtering them at transport boundaries by default is particularly important.

Routes that reference the constants symbolically (for example
`setHeader(ShiroSecurityConstants.SHIRO_SECURITY_USERNAME, ...)`) continue to
work without changes. Routes that set the header by its literal string value
(for example `setHeader("SHIRO_SECURITY_USERNAME", ...)`) must be updated to
use the new value (`setHeader("CamelShiroSecurityUsername", ...)`).


=== camel-web3j - potential breaking change

The Exchange header constants in `Web3jConstants` have been renamed to follow the
Expand Down