Improve the debug logs for insufficient IOPS on storage allocation

[nvazquez]

Description

This PR improves the logging messages on storage pool allocation for insufficient IOPS.

Add a debug log at the point of failure with capacityIops, usedIops and requestedIops.

The message follows the same style as the existing "Insufficient un-allocated capacity on: X for storage allocation, ..." logs in checkPoolforSpace, so both read the same way when grepping allocation traces.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[Pearl1594]

code lgtm

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.67%. Comparing base (a951ac6) to head (a9ad673).

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #13579   +/-   ##
=========================================
  Coverage     17.67%   17.67%           
- Complexity    15797    15798    +1     
=========================================
  Files          5923     5923           
  Lines        533349   533354    +5     
  Branches      65248    65249    +1     
=========================================
+ Hits          94253    94259    +6     
+ Misses       428437   428436    -1     
  Partials      10659    10659           

Flag	Coverage Δ
uitests	3.69% <ø> (ø)
unittests	18.74% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18522

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-16519)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 59534 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13579-t16519-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[Damans227]

LGTM. Tiny nit, feel free to ignore: the StringBuilder is a bit much for two strings, a simple if plus string concat would do the same. Nice addition, this will help when debugging allocation failures.