core: introduce a set of type adapters#13624
Conversation
…ble to correctly communicate between Management Servers and Agents
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13624 +/- ##
============================================
+ Coverage 17.60% 17.70% +0.09%
- Complexity 15664 15840 +176
============================================
Files 5917 5930 +13
Lines 531493 533607 +2114
Branches 64977 65279 +302
============================================
+ Hits 93570 94466 +896
- Misses 427369 428455 +1086
- Partials 10554 10686 +132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 18582 |
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18584 |
|
@blueorangutan test |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-16576) |
|
@blueorangutan test |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-16577)
|
| GsonBuilder loggerBuilder = new GsonBuilder(); | ||
| loggerBuilder.disableHtmlEscaping(); | ||
| loggerBuilder.setExclusionStrategies(new LoggingExclusionStrategy(LOGGER)); | ||
| } |
There was a problem hiding this comment.
It looks like loggerBuilder is never used after being configured, and LOGGER is only used by these lines. Can these be removed?
| */ | ||
|
|
||
| public class AbstractTOAdaptor<T> implements JsonSerializer<T> { | ||
| private static final Logger LOGGER = LogManager.getLogger(AbstractTOAdaptor.class); |
There was a problem hiding this comment.
Small one: the blank line between the javadoc and the class declaration means it is not picked up as javadoc. Can we remove it?
|
|
||
| public class AbstractTOAdaptor<T> implements JsonSerializer<T> { | ||
| private static final Logger LOGGER = LogManager.getLogger(AbstractTOAdaptor.class); | ||
| private static final Gson gson; |
There was a problem hiding this comment.
Should this class be declared abstract, since it is named Abstract and only meant to be subclassed?
| loggerBuilder.setExclusionStrategies(new LoggingExclusionStrategy(LOGGER)); | ||
| } | ||
|
|
||
| private Map<String, String> fieldMappings; |
5 participants
Description
This PR fixes the issue that There is a set of TO classes with renamed fields, which makes impossible to correctly communicate between Management Servers and Agents
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?