ios: rename variables cameraPicker to cdvUIImagePickerController

[GitToTheHub]

• Make clear, that CDVUIImagePickerController is used for these variables

Platforms affected

Motivation and Context

Description

Testing

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[dpogue]

This feels a bit like refactoring for the sake of refactoring and making the code harder to read by using more complex variable names that don't indicate their purpose.

In particular, weakCDVUIImagePickerController is a weird name to use for a variable. It doesn't matter if it's a weak reference or not, it works like any other variable. The only reason weakSelf is a convention is because you need to explicitly create a variable to hold the weak reference.

[GitToTheHub]

I know sometimes the variables get longer during refactoring. This is always something to distinguish what is better. I just wanted to be complete with the renaming of cdvCamera sind it is a UIImagePickerController and not a Camera class. I thought it's a convention to prefix a variable when it's a weak variable. But when you say it's not i will remove it.

[GitToTheHub]

I renamed weakCDVUIImagePickerController to cdvUIImagePickerController