Open
Conversation
DAFFODIL-3076
Contributor
|
I think you might have missed the NOTICE in the root of the project directory. Also do we want to update all the ones in the daffodil-cli/bin.* ? |
jadams-tresys
approved these changes
Mar 2, 2026
Contributor
jadams-tresys
left a comment
There was a problem hiding this comment.
+1 with the ones missed included (assuming they should be updated).
Member
Author
|
Good catch. Should be good now, let me know if I missed any others. |
Contributor
Member
Author
|
The content in our NOTICE file should be a copy/paste of our dependencies' NOTICE files. So even if their copyright years are old, we still shouldn't update them. Instead we should wait until a dependency creates a new release and then update our NOTICE file to match theirs if they have made any changes. So we don't need to make any changes for dependencies yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

DAFFODIL-3076