ci: add dedicated RAT license check workflow for all PRs#3664
Merged
mbutrovich merged 4 commits intoapache:mainfrom Mar 11, 2026
Merged
ci: add dedicated RAT license check workflow for all PRs#3664mbutrovich merged 4 commits intoapache:mainfrom
mbutrovich merged 4 commits intoapache:mainfrom
Conversation
The existing build workflows (pr_build_linux, spark_sql_test, etc.) use paths-ignore to skip docs-only changes, which also skips the RAT license header check. This allowed files without Apache license headers to be merged via docs-only PRs. Add a lightweight dedicated workflow that runs RAT on all PRs with no path filters. Uses -N (non-recursive) to skip child module builds since RAT scans the full directory tree from the parent pom.
Contributor
|
This might be a good opportunity to start using ubuntu-slim. For context, apache/iceberg-rust#2187
|
Contributor
|
I opened an issue to track broader ubuntu-slim use. #3665 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr_rat_check.yml) that runs the Apache RAT license header check on all PRs, including docs-only changesProblem
The existing build workflows (
pr_build_linux,spark_sql_test, etc.) usepaths-ignoreto skip docs-only changes (matchingdocs/**,**.md, etc.). This also skips the RAT license check, which allowed files without Apache license headers to be merged via docs-only PRs (e.g., #3651 introduced SVG files without headers, breaking CI for unrelated PRs like #3661).Solution
A dedicated workflow that:
./mvnw -B -N apache-rat:check(the-Nflag skips child module builds)Test plan