Skip to content

Generic: Add spacing around dot in compound field access adjacent to numbers - #2543

Merged
LucaCappelletti94 merged 3 commits into
mainfrom
compound-field-access-number-spacing
Oct 1, 2026
Merged

LucaCappelletti94 merged 3 commits into
mainfrom
compound-field-access-number-spacing

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

This PR renders compound field access with spaces around . when adjacent to a numeric expression (e.g. 1 . i or (a . 1 . b)), preventing tokens from merging into decimal numeric literals on roundtrip display.

SELECT (1 . i);
-- Formatted as: SELECT (1.i)
-- Re-parse error: Expected: ), found: i

@LucaCappelletti94 LucaCappelletti94 added bug Something isn't working fuzzer A bug found by the fuzzer labels Sep 22, 2026
@LucaCappelletti94
LucaCappelletti94 marked this pull request as ready for review September 22, 2026 11:48
@LucaCappelletti94
LucaCappelletti94 force-pushed the compound-field-access-number-spacing branch 3 times, most recently from 905adcd to 9a321be Compare September 22, 2026 21:03
@LucaCappelletti94
LucaCappelletti94 force-pushed the compound-field-access-number-spacing branch from 9a321be to bd832b0 Compare September 23, 2026 22:23
@codecov-commenter

codecov-commenter commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.10%. Comparing base (bfc7d38) to head (1b6328d).

Files with missing lines Patch % Lines
src/ast/mod.rs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2543   +/-   ##
=======================================
  Coverage   81.09%   81.10%           
=======================================
  Files          42       42           
  Lines       33682    33684    +2     
  Branches    33682    33684    +2     
=======================================
+ Hits        27316    27318    +2     
  Misses       2796     2796           
  Partials     3570     3570           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LucaCappelletti94

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit b1d1486 Oct 1, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fuzzer A bug found by the fuzzer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants