Skip to content

MsSql: Disallow unquoted FROM keyword as alias assignment expression - #2546

Merged
LucaCappelletti94 merged 5 commits into
mainfrom
fix-eq-alias-assignment-from
Oct 1, 2026
Merged

LucaCappelletti94 merged 5 commits into
mainfrom
fix-eq-alias-assignment-from

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

In dialects supporting = alias assignment (T-SQL/MsSql), SELECT a = FROM previously parsed as an alias assignment (SelectItem::ExprWithAlias) with FROM as the expression. This displayed as SELECT FROM AS a, which fails to re-parse because unquoted FROM is not a valid expression in a select item list. Now the round trip works as expected.

@LucaCappelletti94 LucaCappelletti94 added bug Something isn't working fuzzer A bug found by the fuzzer labels Sep 22, 2026
@LucaCappelletti94
LucaCappelletti94 marked this pull request as ready for review September 22, 2026 18:01
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.10%. Comparing base (bfc7d38) to head (837dc7a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2546   +/-   ##
=======================================
  Coverage   81.09%   81.10%           
=======================================
  Files          42       42           
  Lines       33682    33687    +5     
  Branches    33682    33687    +5     
=======================================
+ Hits        27316    27321    +5     
  Misses       2796     2796           
  Partials     3570     3570           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit 8f4da49 Oct 1, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fuzzer A bug found by the fuzzer SQL Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants