Skip to content

SQLite: Support string literals as column names in CREATE TABLE - #2560

Merged
LucaCappelletti94 merged 4 commits into
apache:mainfrom
LucaCappelletti94:sqlite-string-column-names
Oct 1, 2026
Merged

LucaCappelletti94 merged 4 commits into
apache:mainfrom
LucaCappelletti94:sqlite-string-column-names

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

This PR lets SQLiteDialect parse single-quoted strings as column names in CREATE TABLE, which SQLite accepts as names.

CREATE TABLE '""' ('id' INT UNSIGNED NOT NULL, 'name' TEXT NOT NULL);
-- Previously: Expected: column name or constraint definition, found: 'id'

See the SQLite CREATE TABLE documentation.

Closes #322

@LucaCappelletti94 LucaCappelletti94 added enhancement New feature or request fuzzer A bug found by the fuzzer labels Sep 23, 2026
@LucaCappelletti94
LucaCappelletti94 marked this pull request as ready for review September 23, 2026 13:47
@alamb
alamb added this pull request to the merge queue Sep 24, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Sep 24, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.10%. Comparing base (bfc7d38) to head (c95884f).

Files with missing lines Patch % Lines
src/parser/mod.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2560   +/-   ##
=======================================
  Coverage   81.09%   81.10%           
=======================================
  Files          42       42           
  Lines       33682    33691    +9     
  Branches    33682    33691    +9     
=======================================
+ Hits        27316    27324    +8     
  Misses       2796     2796           
- Partials     3570     3571    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 1, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 1, 2026
@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 1, 2026
Merged via the queue into apache:main with commit fc18670 Oct 1, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fuzzer A bug found by the fuzzer SQLite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected failure parsing SQLite CREATE TABLE statement

3 participants