chore: Add TPCDS benchmark comparison for PR #19552
Open
+22
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
commented
Dec 29, 2025
| use crate::udf_eq::UdfEq; | ||
| use crate::{ColumnarValue, Documentation, Expr, Signature}; | ||
| use arrow::datatypes::{DataType, Field, FieldRef}; | ||
| #[cfg(debug_assertions)] |
Contributor
Author
There was a problem hiding this comment.
clippy complains on this when building benchmarks
Contributor
Author
|
@Jefffrey if you can take a quick look |
Jefffrey
approved these changes
Jan 2, 2026
benchmarks/README.md
Outdated
| ```shell | ||
| export DATA_DIR=../../datafusion-benchmarks/tpcds/data/sf1/ | ||
| export PR_NUMBER=19464 | ||
| gh pr checkout $PR_NUMBER --repo apache/datafusion -b pr-$PR_NUMBER |
Contributor
There was a problem hiding this comment.
Suggested change
| gh pr checkout $PR_NUMBER --repo apache/datafusion -b pr-$PR_NUMBER | |
| git fetch upstream pull/$PR_NUMBER/head:pr-$PR_NUMBER |
If we don't want to require gh CLI; this is the command I've been using to clone PRs locally
Contributor
Author
There was a problem hiding this comment.
Thanks, I'll add alternative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?