allow range to satisfy key distribution generally#23680
Conversation
de0572d to
7df0261
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23680 +/- ##
==========================================
- Coverage 80.71% 80.71% -0.01%
==========================================
Files 1089 1089
Lines 368748 368741 -7
Branches 368748 368741 -7
==========================================
- Hits 297633 297614 -19
- Misses 53372 53374 +2
- Partials 17743 17753 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
cc: @gabotechs |
| } | ||
|
|
||
| #[test] | ||
| fn test_partitioning_partial_overlap() -> Result<()> { |
There was a problem hiding this comment.
I see some tests where deleted here? are they no longer relevant?
There was a problem hiding this comment.
I just consolidated these into the test_partitioning_key_satisfaction() test. Actually after you pointing this out I think I will rename this test_hash_partitioning_key_satisfaction() and then keep the test_range_partitioning_key_satisfaction()
I got rid of some case that were repearting testing the same code path such as:
"KeyPartitioned([a, b, c]) satisfied by Hash([b, a])"
and
"KeyPartitioned([a, b, c]) satisfied by Hash([a, b])"
There was a problem hiding this comment.
were there any that popped out to you as bad to remove?
There was a problem hiding this comment.
None specifically, just pointing it out so that we don't loose coverage. If we are still covered, then it should be good 👍
There was a problem hiding this comment.
Sounds good. I will double check when renaming test
There was a problem hiding this comment.
renamed and went over tests to ensure we didn't lose coverage.
I added back: Hash([unknown]) vs KeyPartitioned([unknown,a]) to check an unknown cant match itself in subset
7df0261 to
b173254
Compare
b173254 to
03518df
Compare
Which issue does this PR close?
Partitioning::Rangeto satisfyDistribution::KeyPartitionedgenerally #23266.Rationale for this change
Partitioning::Rangenow satisfiesDistribution::KeyPartitionedprivately across all operators that require it: aggregates, windows, TopK, and co-partitioned joins. So now the temporary operator opt-ins can be consolidated.What changes are included in this PR?
Partitioning::Rangeto satisfyDistribution::KeyPartitionedviaPartitioning::satisfactionAre these changes tested?
Yes
Are there any user-facing changes?
No, this should not change any exisitng behavior just consolidation