fix: track the time takes to init loser tree and build last in progress batches#23698
Open
rluvaton wants to merge 1 commit into
Open
fix: track the time takes to init loser tree and build last in progress batches#23698rluvaton wants to merge 1 commit into
rluvaton wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23698 +/- ##
==========================================
- Coverage 80.67% 80.67% -0.01%
==========================================
Files 1088 1088
Lines 367591 367592 +1
Branches 367591 367592 +1
==========================================
- Hits 296563 296546 -17
- Misses 53374 53385 +11
- Partials 17654 17661 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
My latest rewrite to
SortPreservingMergeStreamforgot to remove comment and to count the initial loser tree init + last in progress emit timeWhat changes are included in this PR?
Are these changes tested?
No, since it is tricky to test that and any attempt can be flaky by design
Are there any user-facing changes?
No