refactor: share join input unparsing - #24965
Draft
Xuanwo wants to merge 10 commits into
Draft
Conversation
# Conflicts: # datafusion/expr/src/logical_plan/builder.rs # datafusion/expr/src/logical_plan/plan.rs
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24965 +/- ##
==========================================
+ Coverage 81.57% 81.68% +0.10%
==========================================
Files 1123 1124 +1
Lines 410789 413490 +2701
Branches 410789 413490 +2701
==========================================
+ Hits 335120 337765 +2645
+ Misses 55913 55829 -84
- Partials 19756 19896 +140 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Regular and ASOF join unparsing separately handled projected inputs, nested right joins, and output projection reconstruction. Keeping those branches separate makes fixes easy to apply to one join kind but miss the other.
GitHub shows the cumulative stack because fork branches cannot be selected as upstream PR bases. The isolated diff is:
Xuanwo/datafusion@xuanwo/asof-sql...xuanwo/asof-unparser-refactor
What changes are included in this PR?
JoinInputMode.Are these changes tested?
Yes:
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo test -p datafusion-sql --test sql_integrationAre there any user-facing changes?
No. This is a behavior-preserving unparser refactor.