fix(config-ui): Recover "Create a New Connection" action#8952
Open
kirillNevedrov wants to merge 1 commit into
Open
fix(config-ui): Recover "Create a New Connection" action#8952kirillNevedrov wants to merge 1 commit into
kirillNevedrov wants to merge 1 commit into
Conversation
kirillNevedrov
changed the title
kirillNevedrov
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes "Create a New Connection" action. The issue is that clicking the "Create a New Connection" button causes
Error: Objects are not valid as a React childerror. It happens because react event object is passed as a pluginName argument to handleShowFormDialog function on button click. So the fix calls onCreate function with no arguments.Does this close any open issues?
No
Screenshots