-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](s3) use ak+sk combine in calculate hash value #60149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 30967 ms |
TPC-DS: Total hot run time: 172512 ms |
ClickBench: Total hot run time: 26.84 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Problem Summary:
because the S3ClientConf will calculate hash use eg: ak、sk、token,
and use the hash value as key to maintain a cache,
if someone swapped AK/SK order by mistake, it's will get connect failed
when get the ak/sk order correctly, it's still get connect failed, because it's have the same hash value.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)