[fix](paimon) Fix Paimon time-travel tag reads for expired snapshots #60166
+82
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run external |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31070 ms |
TPC-DS: Total hot run time: 171826 ms |
ClickBench: Total hot run time: 26.66 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
morningman
approved these changes
Jan 24, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
zhangstar333
approved these changes
Jan 26, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 26, 2026
…60166) ### What problem does this PR solve? - Related PR: #53327 ## Problem Queries like `FOR VERSION AS OF '<tag>'` fail when the tag points to a snapshot whose snapshot file has expired, even though the tag is still valid and data should be retained by tag. ## Root Cause Doris always translated time-travel requests into `scan.snapshot-id`. Paimon validates snapshot-id against the current snapshot range; once a snapshot file is expired, it is out of range and the query fails. Tag-based reads should use `scan.tag-name` instead, which bypasses that snapshot range validation. ## Fix Use `scan.tag-name` for tag-based time travel (`@tag` and `FOR VERSION AS OF '<tag>'`), and keep `scan.snapshot-id` only for numeric snapshot-id queries. Add regression coverage that: - validates tag reads succeed after snapshot expiration - validates direct snapshot-id reads against expired snapshots still fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem
Queries like
FOR VERSION AS OF '<tag>'fail when the tag points to a snapshot whose snapshot file has expired, even though the tag is still valid and data should be retained by tag.Root Cause
Doris always translated time-travel requests into
scan.snapshot-id. Paimon validates snapshot-id against the current snapshot range; once a snapshot file is expired, it is out of range and the query fails. Tag-based reads should usescan.tag-nameinstead, which bypasses that snapshot range validation.Fix
Use
scan.tag-namefor tag-based time travel (@tagandFOR VERSION AS OF '<tag>'), and keepscan.snapshot-idonly for numeric snapshot-id queries. Add regression coverage that:Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)