Revert "[Fix](variance) Fix sample variance/stddev NaN res for single value"#64099
Open
linrrzqqq wants to merge 1 commit into
Open
Revert "[Fix](variance) Fix sample variance/stddev NaN res for single value"#64099linrrzqqq wants to merge 1 commit into
linrrzqqq wants to merge 1 commit into
Conversation
… value (…" This reverts commit d7c033f.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review result: request changes. The PR reverts the previous behavior but introduces a data correctness regression for variance_samp/stddev_samp on singleton groups: BE writes 0.0 for count < 2 in common grouped/non-null paths, which is not the SQL NULL result expected for sample variance/stddev.
Critical checkpoint conclusions:
- Goal/test: The goal appears to revert #63605 and update expected outputs, but the new outputs demonstrate incorrect singleton sample aggregate results as 0.0. Existing tests were updated to accept the regression rather than prove correct behavior.
- Scope: The implementation change is small, but it changes core aggregate semantics.
- Concurrency/lifecycle/config/compatibility: No new concurrency, lifecycle, config, storage format, or FE-BE protocol compatibility concerns found.
- Parallel paths: The issue affects grouped aggregate/window/intermediate aggregate-state paths where the result column is non-nullable or only the nested column is passed.
- Test coverage/results: Regression outputs were modified, but they now encode the incorrect 0.0 singleton result; the removed one-row aggregate assertion also reduces direct coverage.
- Observability/transactions/persistence: Not applicable.
- Performance: No material performance issue found in this diff.
User focus: no additional user-provided review focus was specified.
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
TPC-H: Total hot run time: 29062 ms |
Contributor
TPC-DS: Total hot run time: 169320 ms |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #63605