Skip to content

[improvement](be) Avoid eager formatting in hot paths #66366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mryange wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −10
Open

[improvement](be) Avoid eager formatting in hot paths #66366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions be/src/cloud/cloud_tablet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1540,14 +1540,14 @@ Status CloudTablet::check_delete_bitmap_cache(int64_t txn_id,
Status st = engine.txn_delete_bitmap_cache().get_delete_bitmap(
txn_id, tablet_id(), &cached_delete_bitmap, nullptr, nullptr);
if (st.ok()) {
bool res = (expected_delete_bitmap->cardinality() == cached_delete_bitmap->cardinality());
auto msg = fmt::format(
"delete bitmap cache check failed, cur_cardinality={}, cached_cardinality={}"
"txn_id={}, tablet_id={}",
expected_delete_bitmap->cardinality(), cached_delete_bitmap->cardinality(), txn_id,
tablet_id());

@HappenLee HappenLee Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

错误字符串中 cached_cardinality={} 与 txn_id={} 之间缺少逗号或空格，最终会输出成
cached_cardinality=10txn_id 这个问题顺手修了吧, `然后补一个arrow largetint的nullable的处理用例 现在ut里面是非null的

if (!res) {
DCHECK(res) << msg;
const auto expected_cardinality = expected_delete_bitmap->cardinality();
const auto cached_cardinality = cached_delete_bitmap->cardinality();
if (expected_cardinality != cached_cardinality) {
auto msg = fmt::format(
"delete bitmap cache check failed, cur_cardinality={}, cached_cardinality={}"
"txn_id={}, tablet_id={}",
expected_cardinality, cached_cardinality, txn_id, tablet_id());
DCHECK_EQ(expected_cardinality, cached_cardinality) << msg;
return Status::InternalError<false>(msg);
}
}
Expand Down
4 changes: 2 additions & 2 deletions be/src/core/data_type_serde/data_type_number_serde.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,12 +583,12 @@ Status DataTypeNumberSerDe<T>::write_column_to_arrow(const IColumn& column, cons
} else if constexpr (T == TYPE_LARGEINT) {
auto& string_builder = assert_cast<arrow::StringBuilder&>(*array_builder);
for (size_t i = start; i < end; ++i) {
auto& data_value = col_data[i];
std::string value_str = fmt::format("{}", data_value);
if (null_map && (*null_map)[i]) {
RETURN_IF_ERROR(
checkArrowStatus(string_builder.AppendNull(), column, *array_builder));
} else {
const auto& data_value = col_data[i];
std::string value_str = fmt::format("{}", data_value);
RETURN_IF_ERROR(checkArrowStatus(
string_builder.Append(value_str.data(),
cast_set<int, size_t, false>(value_str.length())),
Expand Down
Loading