branch-4.1: [fix](reverted index) Validate nested variant MATCH predicates #66207 - #66394
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](reverted index) Validate nested variant MATCH predicates #66207#66394github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Related PR: #61190 Problem Summary: Root VARIANT MATCH predicates were rejected only when the Match expression was a top-level filter conjunct. A Match nested under OR could bypass frontend analysis and reach backend execution, where it failed with an unrelated runtime error. Recursively collect Match expressions from each filter expression and apply the existing operand and root Variant validation to every Match node. Add focused FE unit and regression coverage for a mixed text/root Variant OR predicate. ### Release note Reject MATCH predicates on VARIANT root columns even when nested in compound filter expressions. ### Check List (For Author) - Test: Regression test / Unit Test - `./run-regression-test.sh --run -d search -s test_disable_root_variant_match` (failed before the fix and passed after it) - `./run-fe-ut.sh --run org.apache.doris.nereids.rules.rewrite.CheckMatchExpressionTest` - `./build.sh --fe` - Behavior changed: Yes. Nested root VARIANT MATCH predicates now fail during FE analysis, consistent with direct predicates. - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #66207