build(deps): Bump caffeine to 3.2.4 and errorprone to 2.49.0#19527
Open
amaechler wants to merge 1 commit into
Open
build(deps): Bump caffeine to 3.2.4 and errorprone to 2.49.0#19527amaechler wants to merge 1 commit into
caffeine to 3.2.4 and errorprone to 2.49.0#19527amaechler wants to merge 1 commit into
Conversation
amaechler
changed the title
caffeine to 3.2.4 and errorprone to 2.49.0caffeine to 3.2.4 and errorprone to 2.49.0
Caffeine 3 raised the Java baseline to 11, tightened the AsyncCache surface, and replaced size-LRU eviction with W-TinyLFU with explicit admission control. The Caffeine APIs Druid uses (Cache, Caffeine builder, Weigher, CacheStats) are stable across the transition. Errorprone 2.49.0 is required because caffeine 3.2.4 pulls error_prone_annotations 2.49.0 transitively, which violates the requireUpperBoundDeps enforcer rule without the bump. CaffeineCacheTest.testSizeEviction is rewritten for W-TinyLFU: the old test pre-read key1 multiple times before putting key2, biasing the admission policy to keep key1 and reject val2, so the assertion that key1 was evicted no longer holds. The rewrite avoids the pre-reads and asserts only that eviction happened and the cache stayed under bound, mirroring caffeine's own EvictionTest patterns. Also adds the previously-missing license entry for org.jspecify:jspecify 1.0.0 in extensions-core/kubernetes-extensions, which the check-licenses dependency report flags. This was missing pre-bump and is unrelated to caffeine/errorprone, but the CI license check fails without it, so it is included here to keep the PR green.
amaechler
force-pushed
the
bump-caffeine-3.2-errorprone-2.49
branch
from
a02af28 to
3d51036
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps two dependencies,
caffeine(2.9.3to3.2.4), anderrorprone(2.41.0to2.49.0). They update goes together becausecaffeinepulls inerror_prone_annotationstransitively, which violatesrequireUpperBoundDepswithout theerrorpronebump.Rewrote CaffeineCacheTest.testSizeEviction
The old test assumed that when the cache exceeded its size limit, the first-inserted entry was always the one evicted, but caffeine 3's eviction policy can keep either entry based on access frequency. The rewrite asserts only that eviction happened and the cache stayed within its size bound, not which specific key was kept.
This PR has: