Skip to content

FINERACT-2801: Remove unused (dead) code in fineract-core #6376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamaSVM wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

FINERACT-2801: Remove unused (dead) code in fineract-core #6376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/domain/Charge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,6 @@ public boolean isAllowedLoanChargeTime() {
return ChargeTimeType.fromInt(this.chargeTimeType).isAllowedLoanChargeTime();
}

public boolean isAllowedClientChargeTime() {
return ChargeTimeType.fromInt(this.chargeTimeType).isAllowedClientChargeTime();
}

public boolean isSavingsCharge() {
return ChargeAppliesTo.fromInt(this.chargeAppliesTo).isSavingsCharge();
}
Expand Down
26 changes: 0 additions & 26 deletions ...java/org/apache/fineract/infrastructure/core/exception/ImageDataURLNotValidException.java
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions ...src/main/java/org/apache/fineract/infrastructure/core/exception/ImageUploadException.java
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions ...main/java/org/apache/fineract/infrastructure/dataqueries/data/DatatableSearchRequest.java
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions ...act-core/src/main/java/org/apache/fineract/infrastructure/jobs/data/JobParametersDTO.java
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions ...rc/main/java/org/apache/fineract/infrastructure/security/utils/SQLInjectionException.java
View file
Open in desktop

This file was deleted.

44 changes: 0 additions & 44 deletions .../main/java/org/apache/fineract/organisation/monetary/serialization/MoneyDeserializer.java
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions ...rc/main/java/org/apache/fineract/organisation/monetary/serialization/MoneySerializer.java
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions fineract-core/src/main/java/org/apache/fineract/organisation/staff/domain/Staff.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,4 @@ public class Staff extends AbstractPersistableCustom<Long> {

@Column(name = "image_id")
private Long imageId;

// TODO: these functions are mistakenly included in an API serialization

@Deprecated(forRemoval = true)
public boolean isNotLoanOfficer() {
return !isLoanOfficer();
}

@Deprecated(forRemoval = true)
public boolean isNotActive() {
return !isActive();
}
}
9 changes: 0 additions & 9 deletions fineract-core/src/main/java/org/apache/fineract/portfolio/charge/domain/ChargeTimeType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,6 @@ public static Object[] validWorkingCapitalLoanValues() {
return validWorkingCapitalLoan().stream().map(ChargeTimeType::getValue).toArray();
}

public static Object[] validLoanChargeValues() {
return new Integer[] { ChargeTimeType.DISBURSEMENT.getValue(), ChargeTimeType.SPECIFIED_DUE_DATE.getValue(),
ChargeTimeType.INSTALMENT_FEE.getValue() };
}

public static Object[] validSavingsValues() {
return new Integer[] { ChargeTimeType.SPECIFIED_DUE_DATE.getValue(), ChargeTimeType.SAVINGS_ACTIVATION.getValue(),
ChargeTimeType.SAVINGS_CLOSURE.getValue(), ChargeTimeType.WITHDRAWAL_FEE.getValue(), ChargeTimeType.ANNUAL_FEE.getValue(),
Expand Down Expand Up @@ -203,10 +198,6 @@ public boolean isAllowedLoanChargeTime() {
return isTimeOfDisbursement() || isOnSpecifiedDueDate() || isInstalmentFee() || isOverdueInstallment() || isTrancheDisbursement();
}

public boolean isAllowedClientChargeTime() {
return isOnSpecifiedDueDate();
}

public boolean isAllowedSavingsChargeTime() {
return isOnSpecifiedDueDate() || isSavingsActivation() || isSavingsClosure() || isWithdrawalFee() || isAnnualFee() || isMonthlyFee()
|| isWeeklyFee() || isOverdraftFee() || isSavingsNoActivityFee();
Expand Down
Loading