Skip to content

FINERACT-2801: Remove unused (dead) code in fineract-savings #6380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamaSVM wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

FINERACT-2801: Remove unused (dead) code in fineract-savings #6380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...-savings/src/main/java/org/apache/fineract/interoperation/data/InteropIdentifierData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ public class InteropIdentifierData {

private final String subIdOrType;

protected InteropIdentifierData(@NotNull InteropIdentifierType idType, @NotNull String idValue) {
this(idType, idValue, null);
}

public static InteropIdentifierData build(InteropIdentifier identifier) {
return new InteropIdentifierData(identifier.getType(), identifier.getValue(), identifier.getSubType());
}
Expand Down
64 changes: 0 additions & 64 deletions ...ache/fineract/portfolio/charge/exception/SavingsAccountChargeCannotBeWaivedException.java
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions ...savings/src/main/java/org/apache/fineract/portfolio/savings/data/TransactionDateData.java
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions ...act-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/GSIMRepositoy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
public interface GSIMRepositoy
extends JpaRepository<GroupSavingsIndividualMonitoring, Long>, JpaSpecificationExecutor<GroupSavingsIndividualMonitoring> {

GroupSavingsIndividualMonitoring findOneByIsAcceptingChild(boolean acceptingChild);

GroupSavingsIndividualMonitoring findOneByIsAcceptingChildAndApplicationId(boolean acceptingChild, BigDecimal applicationId);

GroupSavingsIndividualMonitoring findOneByAccountNumber(String accountNumber);
Expand Down
22 changes: 0 additions & 22 deletions ...org/apache/fineract/portfolio/savings/domain/SavingsAccountTransactionSummaryWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,6 @@ public BigDecimal calculateTotalInterestPosted(final MonetaryCurrency currency,
return total.getAmountDefaultedToNullIfZero();
}

public BigDecimal calculateTotalInterestPosted(final MonetaryCurrency currency, final BigDecimal currentInterestPosted,
final List<SavingsAccountTransaction> savingsAccountTransactions) {
Money total = Money.of(currency, currentInterestPosted);
for (final SavingsAccountTransaction transaction : savingsAccountTransactions) {
if (transaction.isInterestPostingAndNotReversed() && transaction.isNotReversed() && !transaction.isReversalTransaction()) {
total = total.plus(transaction.getAmount(currency));
}
}
return total.getAmountDefaultedToNullIfZero();
}

public BigDecimal calculateTotalWithdrawalFees(final MonetaryCurrency currency, final List<SavingsAccountTransaction> transactions) {
Money total = Money.zero(currency);
for (final SavingsAccountTransaction transaction : transactions) {
Expand Down Expand Up @@ -134,17 +123,6 @@ public BigDecimal calculateTotalPenaltyChargeWaived(final MonetaryCurrency curre
return total.getAmountDefaultedToNullIfZero();
}

public BigDecimal calculateTotalOverdraftInterest(MonetaryCurrency currency, BigDecimal overdraftPosted,
List<SavingsAccountTransaction> transactions) {
Money total = Money.of(currency, overdraftPosted);
for (final SavingsAccountTransaction transaction : transactions) {
if (transaction.isOverdraftInterestAndNotReversed() && !transaction.isReversalTransaction()) {
total = total.plus(transaction.getAmount(currency));
}
}
return total.getAmountDefaultedToNullIfZero();
}

public BigDecimal calculateTotalOverdraftInterest(MonetaryCurrency currency, List<SavingsAccountTransaction> transactions) {
Money total = Money.zero(currency);
for (final SavingsAccountTransaction transaction : transactions) {
Expand Down
Loading