FINERACT-2801: Remove unused (dead) code in fineract-working-capital-… - #6384
FINERACT-2801: Remove unused (dead) code in fineract-working-capital-…#6384SamaSVM wants to merge 1 commit into
Conversation
galovics
left a comment
There was a problem hiding this comment.
Verified against the actual PR base rather than the local worktree (which has diverged on this file). The removed fields (jobRepository, the @Qualifier("jdbcTransactionManager") jdbcTransactionManager) have no usage anywhere in the class body, and the class itself has zero references anywhere in the repo outside its own declaration, so the constructor-arity change from @RequiredArgsConstructor is safe. No reflection/classgraph/MapStruct surface touches injected field names, so nothing else could break either.
One red CI shard (MySQL Shard 1) looks like unrelated infrastructure flake (actuator health check timeout), not something this change could cause.
Small note for a follow-up, not this PR: the exact same dead pair (jobRepository + jdbcTransactionManager) also exists in the sibling LoanCOBWorkerConfiguration.java, which was clearly the copy-paste source. Worth a separate cleanup PR.
Recommendation: APPROVE
Description
Removes unused code from
fineract-working-capital-loanonly.Removed code with no references found anywhere in the codebase:
WorkingCapitalLoanCOBWorkerConfigurationNo functional changes were introduced; application behavior remains unaffected.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.