Skip to content

FINERACT-2801: Remove unused (dead) code in fineract-working-capital-… - #6384

Open
SamaSVM wants to merge 1 commit into
apache:developfrom
SamaSVM:FINERACT-2801/dead-code-fineract-working-capital-loan
Open

FINERACT-2801: Remove unused (dead) code in fineract-working-capital-…#6384
SamaSVM wants to merge 1 commit into
apache:developfrom
SamaSVM:FINERACT-2801/dead-code-fineract-working-capital-loan

Conversation

@SamaSVM

@SamaSVM SamaSVM commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description

Removes unused code from fineract-working-capital-loan only.

Removed code with no references found anywhere in the codebase:

  • Unused method: method in WorkingCapitalLoanCOBWorkerConfiguration

No functional changes were introduced; application behavior remains unaffected.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@galovics galovics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against the actual PR base rather than the local worktree (which has diverged on this file). The removed fields (jobRepository, the @Qualifier("jdbcTransactionManager") jdbcTransactionManager) have no usage anywhere in the class body, and the class itself has zero references anywhere in the repo outside its own declaration, so the constructor-arity change from @RequiredArgsConstructor is safe. No reflection/classgraph/MapStruct surface touches injected field names, so nothing else could break either.

One red CI shard (MySQL Shard 1) looks like unrelated infrastructure flake (actuator health check timeout), not something this change could cause.

Small note for a follow-up, not this PR: the exact same dead pair (jobRepository + jdbcTransactionManager) also exists in the sibling LoanCOBWorkerConfiguration.java, which was clearly the copy-paste source. Worth a separate cleanup PR.

Recommendation: APPROVE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants