Skip to content

FINERACT-848: Add ability to define custom interest rate in fixed and recurring deposit accounts - #6405

Open
Eyad-Sharkawy wants to merge 1 commit into
apache:developfrom
Eyad-Sharkawy:FINERACT-848
Open

FINERACT-848: Add ability to define custom interest rate in fixed and recurring deposit accounts#6405
Eyad-Sharkawy wants to merge 1 commit into
apache:developfrom
Eyad-Sharkawy:FINERACT-848

Conversation

@Eyad-Sharkawy

Copy link
Copy Markdown
Contributor

Description

Resolves FINERACT-848.

Adds the ability to override product-level interest rate charts with a custom nominal annual interest rate for Fixed Deposit (FD) and Recurring Deposit (RD) accounts:

  • Added isRateChartOverridden boolean flag to deposit account terms and data models.
  • Updated domain interest calculation and validation in FixedDepositAccount and RecurringDepositAccount so that when isRateChartOverridden is enabled, custom nominal annual interest rate takes precedence and bypasses product chart slab lookups.
  • Added API request/response parameters, Swagger documentation annotations, and Liquibase database migration.
  • Added comprehensive unit tests in DepositAccountRateChartOverriddenTest.

Checklist

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green")
  • Create/update unit or integration tests for verifying the changes made
  • Follow our coding conventions
  • Add required Swagger annotation and update API documentation
  • This PR must not be a "code dump"
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately

@Eyad-Sharkawy

Copy link
Copy Markdown
Contributor Author

Hi @Aman-Mittal / reviewers, all 86 test and quality checks passed, but the regression-safety check was cancelled on the baseline step (Instance #1: The operation was canceled). Could someone with write permissions please re-run that failed job? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant