Make flink download caching conditional on a cache miss#46
Open
tomncooper wants to merge 1 commit intoapache:ci_utilsfrom
Open
Make flink download caching conditional on a cache miss#46tomncooper wants to merge 1 commit intoapache:ci_utilsfrom
tomncooper wants to merge 1 commit intoapache:ci_utilsfrom
Conversation
Currently the Java GH Actions CI workflow will try to save the Flink dist download even if it was successfully retrieved in the earlier cache fetch step. This is harmless but leads to warnings in the UI and would be better if it was skipped. Signed-off-by: Thomas Cooper <code@tomcooper.dev>
tomncooper
force-pushed
the
cache-after-miss-only
branch
from
cd82949 to
91ccf61
Compare
davidradl
reviewed
Feb 2, 2026
|
|
||
| - name: Cache Flink binary | ||
| if: ${{ env.cache_binary == 'true' }} | ||
| if: steps.restore-cache-flink.outputs.cache-hit != 'true' |
There was a problem hiding this comment.
We should do ${{ env.cache_binary == 'true' }} as well - so we only do caching processing if caching is specified? i.e. and these 2 conditions with ${{ env.cache_binary == 'true' }} first .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Java CI GH Action workflow will try to save the Flink distribution download to the cache, even if it was successfully retrieved in the earlier cache fetch step.
This is harmless, but leads to warnings in the UI and would be better if it was skipped.