[FLINK-39768][tests][JUnit5 migration] Module: flink-avro - AvroStreamingFileSinkITCase straggler#28263
Open
spuru9 wants to merge 1 commit into
Open
[FLINK-39768][tests][JUnit5 migration] Module: flink-avro - AvroStreamingFileSinkITCase straggler#28263spuru9 wants to merge 1 commit into
spuru9 wants to merge 1 commit into
Conversation
…mingFileSinkITCase straggler Migrate the last remaining JUnit 4 test in flink-avro to JUnit 5: - org.junit.* -> org.junit.jupiter.api.* - @rule Timeout -> class-level @timeout(value = 20) - extends AbstractTestBaseJUnit4 -> extends AbstractTestBase - TEMPORARY_FOLDER.newFolder() -> TempDirUtils.newFolder(temporaryFolder.toPath()) - Drop public modifiers on test class/methods per the migration guide The rest of flink-avro was migrated in FLINK-26232; this file was a leftover.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Migrate the last remaining JUnit 4 test in
flink-formats/flink-avro(AvroStreamingFileSinkITCase) to JUnit 5 (Jupiter). The rest of the module was migrated under FLINK-26232 (fix 1.15.0); this file was a leftover. This is the sole change required to remove JUnit 4 from the module.JIRA: FLINK-39768 (sub-task of FLINK-25325)
Brief change log
org.junit.*imports →org.junit.jupiter.api.*.@Rule public Timeout timeoutPerTest = Timeout.seconds(20)→ class-level@Timeout(value = 20).extends AbstractTestBaseJUnit4→extends AbstractTestBase(the JUnit 5 sibling).TEMPORARY_FOLDER.newFolder()(static@ClassRulefield on the JUnit 4 base) →TempDirUtils.newFolder(temporaryFolder.toPath())(instance@TempDiron the JUnit 5 base).publicon the test class and test methods per the Flink JUnit 5 Migration Guide.No production code is touched.
Verifying this change
Result: 3 tests run, 0 failures, 0 errors, 0 skipped, matching the pre-migration baseline.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?