[#9533] feat(trino-connector): Add UDF adaptation for Trino connector by laserninja · Pull Request #10494 · apache/gravitino

laserninja · 2026-03-21T18:53:50Z

What changes were proposed in this pull request?

Add support for consuming Gravitino function metadata in the Trino connector by mapping SQL functions with RuntimeType.TRINO to Trino's built-in LanguageFunction API.

Why are the changes needed?

CatalogConnectorMetadata: Add FunctionCatalog support with graceful fallback when catalog does not support functions. Add methods to list and retrieve functions from Gravitino server.
GravitinoMetadata: Implement listLanguageFunctions() and getLanguageFunctions() to convert Gravitino SQL functions with TRINO runtime to Trino LanguageFunction instances.
TestGravitinoMetadataFunction: 8 unit tests covering listing, filtering, multiple definitions, signature tokens, and edge cases.
TestCatalogConnectorMetadataFunction: 7 unit tests covering function catalog support detection, listing, retrieval, and error handling.

Fix #9533

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Added test cases.

github-actions · 2026-03-23T03:03:42Z

Code Coverage Report

Overall Project	65.03% `-0.32%`	🟢
Files changed	13.46%	🔴

Module	Coverage
aliyun	1.73%	🔴
api	47.14%	🟢
authorization-common	85.96%	🟢
aws	1.1%	🔴
azure	2.6%	🔴
catalog-common	10.0%	🔴
catalog-fileset	80.02%	🟢
catalog-hive	80.98%	🟢
catalog-jdbc-clickhouse	79.06%	🟢
catalog-jdbc-common	42.89%	🟢
catalog-jdbc-doris	80.28%	🟢
catalog-jdbc-hologres	54.03%	🟢
catalog-jdbc-mysql	79.23%	🟢
catalog-jdbc-oceanbase	78.38%	🟢
catalog-jdbc-postgresql	82.05%	🟢
catalog-jdbc-starrocks	78.27%	🟢
catalog-kafka	77.01%	🟢
catalog-lakehouse-generic	45.07%	🟢
catalog-lakehouse-hudi	79.1%	🟢
catalog-lakehouse-iceberg	87.15%	🟢
catalog-lakehouse-paimon	77.71%	🟢
catalog-model	77.72%	🟢
cli	44.51%	🟢
client-java	77.83%	🟢
common	49.42%	🟢
core	81.13%	🟢
filesystem-hadoop3	76.97%	🟢
flink	38.86%	🔴
flink-runtime	0.0%	🔴
gcp	14.2%	🔴
hadoop-common	10.39%	🔴
hive-metastore-common	45.82%	🟢
iceberg-common	50.0%	🟢
iceberg-rest-server	66.56%	🟢
integration-test-common	0.0%	🔴
jobs	66.17%	🟢
lance-common	23.88%	🔴
lance-rest-server	57.84%	🟢
lineage	53.02%	🟢
optimizer	82.95%	🟢
optimizer-api	21.95%	🔴
server	85.62%	🟢
server-common	70.14%	🟢
spark	32.79%	🔴
spark-common	39.09%	🔴
trino-connector	32.6% `-3.11%`	🔴

Files

Module	File	Coverage
trino-connector	CatalogConnectorMetadata.java	15.67%	🔴
	GravitinoMetadata.java	12.57%	🔴

Copilot

Pull request overview

Adds Trino connector support for consuming Gravitino function metadata by adapting Gravitino SQL UDFs (runtime = TRINO) into Trino LanguageFunction objects, with unit tests validating the behavior.

Changes:

Extend CatalogConnectorMetadata with optional FunctionCatalog support, including graceful fallback when functions aren’t supported.
Implement listLanguageFunctions() and getLanguageFunctions() in GravitinoMetadata, converting Gravitino function definitions/impls into Trino LanguageFunction instances.
Add unit tests for function-catalog detection/listing/retrieval and for language-function conversion/filtering/signature-token behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/CatalogConnectorMetadata.java	Adds function-catalog discovery plus list/get function helpers with fallback when unsupported.
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoMetadata.java	Adds Trino `LanguageFunction` listing/getting by converting Gravitino TRINO SQL impls.
trino-connector/trino-connector/src/test/java/org/apache/gravitino/trino/connector/catalog/TestCatalogConnectorMetadataFunction.java	Tests catalog function support detection, listing, retrieval, and error handling.
trino-connector/trino-connector/src/test/java/org/apache/gravitino/trino/connector/TestGravitinoMetadataFunction.java	Tests conversion/filtering of Gravitino functions to Trino `LanguageFunction`, including signature token cases.

…nector Add support for consuming Gravitino function metadata in the Trino connector by mapping SQL functions with RuntimeType.TRINO to Trino's built-in LanguageFunction API. Changes: - CatalogConnectorMetadata: Add FunctionCatalog support with graceful fallback when catalog does not support functions. Add methods to list and retrieve functions from Gravitino server. - GravitinoMetadata: Implement listLanguageFunctions() and getLanguageFunctions() to convert Gravitino SQL functions with TRINO runtime to Trino LanguageFunction instances. - TestGravitinoMetadataFunction: 8 unit tests covering listing, filtering, multiple definitions, signature tokens, and edge cases. - TestCatalogConnectorMetadataFunction: 7 unit tests covering function catalog support detection, listing, retrieval, and error handling. Fixes apache#9533

laserninja · 2026-03-23T21:55:40Z

@diqiu50 addressed the bot's comments/

diqiu50 · 2026-03-24T09:47:35Z

Please update the PR description to match our format.

laserninja · 2026-03-24T15:52:46Z

Done, I used some closed PR as a reference.

diqiu50

Can you add some integration test for UDF
You can refer to the current Trino integration tests.

laserninja · 2026-03-25T16:11:46Z

Created TrinoUDFIT.java with 4 integration tests tagged @Tag("gravitino-docker-test"):

testListLanguageFunctionsShowsRegisteredUDF which registers a TRINO SQL function via Gravitino client, verifies it appears in Trino via SHOW FUNCTIONS
testListLanguageFunctionsFiltersNonTrinoRuntime which registers a SPARK function, verifies it does NOT appear in Trino
testMultipleUDFsInSameSchema that registers two TRINO functions, verifies both appear
testNoFunctionsWhenSchemaIsEmpty that verifies empty schema has no UDFs

diqiu50

I noticed you added integration tests—why not include test scripts as well, like those in trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets?
Can Trino create functions in Gravitino via SQL?

diqiu50 · 2026-03-27T13:24:16Z

+    }
+    return Arrays.stream(catalogConnectorMetadata.listFunctionInfos(schemaName))
+        .flatMap(function -> toLanguageFunctions(function).stream())
+        .collect(Collectors.toList());


flatMap(XX).toList() is OK

diqiu50 · 2026-03-27T13:26:50Z

+                    Types.IntegerType.get(),
+                    FunctionImpls.of(
+                        FunctionImpls.ofSql(FunctionImpl.RuntimeType.TRINO, "RETURN x + 1")))));
+    Assertions.assertNotNull(function);


Add comments for this function definition

laserninja · 2026-03-28T05:03:52Z

This PR only implements the read path 'listLanguageFunctions'/'getLanguageFunctions'. Trino cannot create functions in Gravitino via SQL yet; the write path (CREATE FUNCTION) is not implemented in this PR. Because of that, the SQL testset approach doesn't work here since we need to register functions via the Gravitino Java client first, then verify them from the Trino side. SQL testsets would be a great fit once the CREATE FUNCTION write path is added in a follow-up.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-30T08:27:47Z

 import org.apache.gravitino.SupportsSchemas;
 import org.apache.gravitino.client.GravitinoMetalake;
 import org.apache.gravitino.exceptions.NoSuchCatalogException;
+import org.apache.gravitino.exceptions.NoSuchFunctionException;


The import for NoSuchFunctionException is unused (it’s only referenced in JavaDoc). Spotless is configured with removeUnusedImports(), so this will fail formatting checks unless removed or referenced in code/JavaDoc using FQN without importing.

Suggested change

import org.apache.gravitino.exceptions.NoSuchFunctionException;

Copilot · 2026-03-30T08:27:48Z

+  /**
+   * Lists all functions with details in the specified schema.
+   *
+   * @param schemaName the name of the schema
+   * @return an array of functions, or an empty array if functions are not supported
+   */
+  public Function[] listFunctionInfos(String schemaName) {
+    if (!supportsFunctions()) {
+      throw new UnsupportedOperationException("Catalog does not support functions");
+    }


JavaDoc for listFunctionInfos says it returns an empty array when functions are not supported, but the method currently throws UnsupportedOperationException in that case. Please align the JavaDoc with the actual behavior (or change the method to match the documented contract).

Copilot · 2026-03-30T08:27:48Z

+        } catch (Exception e) {
+          LOG.warn(
+              "Failed to build signature token for function {}: {}",
+              function.name(),
+              e.getMessage());


toLanguageFunctions catches a generic Exception and logs only e.getMessage(), which can hide the root cause and stack trace (and the repo guidelines discourage catch (Exception e)). Catch the specific expected exceptions (e.g., unsupported type conversion) and include the exception in the log call so failures are diagnosable.

Suggested change

} catch (Exception e) {

LOG.warn(

"Failed to build signature token for function {}: {}",

function.name(),

e.getMessage());

} catch (IllegalArgumentException | UnsupportedOperationException e) {

LOG.warn(

"Failed to build signature token for function {}",

function.name(),

e);

diqiu50 · 2026-03-30T08:45:07Z

+          LOG.warn(
+              "Failed to build signature token for function {}: {}",
+              function.name(),
+              e.getMessage());


missing stack

diqiu50 · 2026-03-30T08:46:11Z

+   * Lists all functions with details in the specified schema.
+   *
+   * @param schemaName the name of the schema
+   * @return an array of functions, or an empty array if functions are not supported


update docs

diqiu50 · 2026-03-30T08:52:29Z

+    LOG.info("SHOW FUNCTIONS for empty schema: {}", result);
+    // For an empty schema, the result should not contain any custom function names
+    Assertions.assertFalse(
+        result.contains("udf_"), "Expected no UDFs in empty schema. Got: " + result);


Can you clarify the criteria here? udf_ is too vague.

diqiu50 · 2026-03-30T08:53:38Z

+
+    LOG.info("SELECT result: {}", result);
+    Assertions.assertTrue(
+        result.contains("10"), "Expected SELECT test_add_five(5) to return 10. Got: " + result);


The same problem

diqiu50 · 2026-03-30T08:55:19Z

+        metadata.getLanguageFunctions(
+            session, new SchemaFunctionName("test_schema", "no_such_func"));
+    assertTrue(functions.isEmpty());
+  }


Add some tests for supportsFunctions=false

diqiu50 · 2026-03-30T09:18:02Z

Can you add some docs for the UDF

laserninja · 2026-03-31T03:41:41Z

Done, created 'udf-support.md'

diqiu50

LGTM

diqiu50 · 2026-03-31T09:28:13Z

@laserninja Please leave a comment on the issue #9533—I can’t assign it to you.

laserninja · 2026-03-31T14:52:04Z

Commented, thanks.

…nector (apache#10494) ### What changes were proposed in this pull request? Add support for consuming Gravitino function metadata in the Trino connector by mapping SQL functions with RuntimeType.TRINO to Trino's built-in LanguageFunction API. ### Why are the changes needed? - CatalogConnectorMetadata: Add FunctionCatalog support with graceful fallback when catalog does not support functions. Add methods to list and retrieve functions from Gravitino server. - GravitinoMetadata: Implement listLanguageFunctions() and getLanguageFunctions() to convert Gravitino SQL functions with TRINO runtime to Trino LanguageFunction instances. - TestGravitinoMetadataFunction: 8 unit tests covering listing, filtering, multiple definitions, signature tokens, and edge cases. - TestCatalogConnectorMetadataFunction: 7 unit tests covering function catalog support detection, listing, retrieval, and error handling. Fix apache#9533 ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Added test cases.

…rino connector (apache#10494)" This reverts commit 7fce6aa.

roryqi requested a review from diqiu50 March 22, 2026 09:51

diqiu50 requested a review from Copilot March 23, 2026 10:17

Copilot started reviewing on behalf of diqiu50 March 23, 2026 10:17 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

laserninja force-pushed the trino-connector-udf-adaptation branch from 1974402 to 3d88499 Compare March 23, 2026 21:53

diqiu50 reviewed Mar 24, 2026

View reviewed changes

laserninja force-pushed the trino-connector-udf-adaptation branch from aeebb2e to 5f4239f Compare March 24, 2026 05:32

diqiu50 assigned laserninja Mar 24, 2026

diqiu50 added 1.3.0 Release v1.3.0 and removed 1.3.0 Release v1.3.0 labels Mar 24, 2026

diqiu50 reviewed Mar 25, 2026

View reviewed changes

Comment thread ...or/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoMetadata.java

laserninja force-pushed the trino-connector-udf-adaptation branch from 5f4239f to aed4474 Compare March 25, 2026 16:09

diqiu50 reviewed Mar 27, 2026

View reviewed changes

laserninja force-pushed the trino-connector-udf-adaptation branch from aed4474 to f9d5505 Compare March 28, 2026 04:59

diqiu50 requested a review from Copilot March 30, 2026 08:17

Copilot started reviewing on behalf of diqiu50 March 30, 2026 08:23 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

diqiu50 reviewed Mar 30, 2026

View reviewed changes

Merge branch 'main' into trino-connector-udf-adaptation

5d6d107

laserninja force-pushed the trino-connector-udf-adaptation branch from f9d5505 to 5d6d107 Compare March 31, 2026 03:32

diqiu50 approved these changes Mar 31, 2026

View reviewed changes

diqiu50 merged commit 9809eed into apache:main Apr 1, 2026
21 checks passed

babumahesh added a commit to babumahesh/gravitino that referenced this pull request Apr 9, 2026

Revert "[apache#9533] feat(trino-connector): Add UDF adaptation for T…

509d39e

…rino connector (apache#10494)" This reverts commit 7fce6aa.

babumahesh added a commit to babumahesh/gravitino that referenced this pull request Apr 9, 2026

Revert "[apache#9533] feat(trino-connector): Add UDF adaptation for T…

6103b4e

…rino connector (apache#10494)" This reverts commit 7fce6aa.

Conversation

laserninja commented Mar 21, 2026 • edited by diqiu50 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

github-actions Bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

laserninja commented Mar 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

diqiu50 commented Mar 24, 2026

Uh oh!

laserninja commented Mar 24, 2026

Uh oh!

diqiu50 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

laserninja commented Mar 25, 2026

Uh oh!

diqiu50 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laserninja commented Mar 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

laserninja commented Mar 21, 2026 •

edited by diqiu50

Loading

github-actions Bot commented Mar 23, 2026 •

edited

Loading

diqiu50 left a comment •

edited

Loading