Skip to content

minor refactor: remove deprecated method usage#2413

Merged
paulk-asert merged 1 commit intoapache:masterfrom
paulk-asert:removeDeprecatedMethodUsageInClosureMetaClass
Apr 1, 2026
Merged

minor refactor: remove deprecated method usage#2413
paulk-asert merged 1 commit intoapache:masterfrom
paulk-asert:removeDeprecatedMethodUsageInClosureMetaClass

Conversation

@paulk-asert
Copy link
Copy Markdown
Contributor

@paulk-asert paulk-asert commented Mar 29, 2026

I am unsure whether the lines removed support legacy behavior not covered by tests or are now covered incidentally by other changes.

@paulk-asert paulk-asert requested a review from eric-milles March 29, 2026 02:32
@paulk-asert paulk-asert force-pushed the removeDeprecatedMethodUsageInClosureMetaClass branch from eb78021 to 38839ab Compare March 30, 2026 06:15
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.3622%. Comparing base (be4ec1c) to head (38839ab).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2413        +/-   ##
==================================================
- Coverage     66.3773%   66.3622%   -0.0151%     
+ Complexity      29877      29874         -3     
==================================================
  Files            1392       1392                
  Lines          116799     116797         -2     
  Branches        20665      20664         -1     
==================================================
- Hits            77528      77509        -19     
- Misses          32915      32938        +23     
+ Partials         6356       6350         -6     
Files with missing lines Coverage Δ
...aus/groovy/runtime/metaclass/ClosureMetaClass.java 71.9298% <ø> (-0.1956%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-milles
Copy link
Copy Markdown
Member

Does it select the first declared one or is it based on index or random order?

@paulk-asert
Copy link
Copy Markdown
Contributor Author

Does it select the first declared one or is it based on index or random order?

It follows the closest match rules. I thought that might leave a gap but I could find any.

@paulk-asert paulk-asert merged commit 2a7d1e9 into apache:master Apr 1, 2026
32 of 33 checks passed
@paulk-asert paulk-asert deleted the removeDeprecatedMethodUsageInClosureMetaClass branch April 1, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants