GROOVY-11888: STC: method resolution fails for UnionTypeClassNode due…

[paulk-asert]

… to premature covariant elimination

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.3838%. Comparing base (3b4d02f) to head (0cf0d9e).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                 @@
##               master      #2415        +/-   ##
==================================================
+ Coverage     66.3773%   66.3838%   +0.0065%     
- Complexity      29877      29906        +29     
==================================================
  Files            1392       1394         +2     
  Lines          116799     116908       +109     
  Branches        20665      20686        +21     
==================================================
+ Hits            77528      77608        +80     
- Misses          32916      32931        +15     
- Partials         6355       6369        +14     

Files with missing lines	Coverage Δ
...roovy/transform/stc/StaticTypeCheckingSupport.java	81.5371% <100.0000%> (-0.0395%)	⬇️

... and 130 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[eric-milles]

Let me have a look at the unit test cases. I wasn't familiar with cases that failed. Were these cases that came from some project?

[eric-milles]

The change looks good overall. I had very minor comments. And I added the failing tests to the jira description.

[paulk-asert]

... Were these cases that came from some project?

I actually asked AI to help me review any edge cases that might be missing for PR #2397. It came up with those test cases and they were applicable to master not just GROOVY_5_0_X.